♻️ (core) [DSDK-558]: Extract transports from core package
#454
+1,663
−1,190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
valpinkman
force-pushed
the
feature/no-issue-poc-extract-transports
branch
from
ccfef4b
to
66b6c78
Compare
valpinkman
force-pushed
the
feature/no-issue-poc-extract-transports
branch
from
db1bbcf
to
e366664
Compare
Comment on lines
+24
to
+49
| ({ | ||
| deviceModelDataSource, | ||
| loggerServiceFactory, | ||
| apduSenderServiceFactory, | ||
| apduReceiverServiceFactory, | ||
| }) => | ||
| new WebHidTransport( | ||
| deviceModelDataSource, | ||
| loggerServiceFactory, | ||
| apduSenderServiceFactory, | ||
| apduReceiverServiceFactory, | ||
| ), | ||
| ) | ||
| .addTransport( | ||
| ({ | ||
| deviceModelDataSource, | ||
| loggerServiceFactory, | ||
| apduSenderServiceFactory, | ||
| apduReceiverServiceFactory, | ||
| }) => | ||
| new WebBleTransport( | ||
| deviceModelDataSource, | ||
| loggerServiceFactory, | ||
| apduSenderServiceFactory, | ||
| apduReceiverServiceFactory, | ||
| ), |
There was a problem hiding this comment.
[SHOULD] export those factories from each transport package, as a default transport factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
WIP
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers