✨ (signer-solana) [DSDK-554]: Add GetAddressUseCase #451
+389
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jdabbech-ledger
approved these changes
Oct 28, 2024
mbertin-ledger
requested changes
Oct 28, 2024
| { | ||
| title: "Get address", | ||
| description: | ||
| "Perform all the actions necessary to get an ethereum address from the device", |
There was a problem hiding this comment.
[MUST] Use Solana
| }); | ||
| }, | ||
| initialValues: { | ||
| derivationPath: "44'/501'", |
There was a problem hiding this comment.
[SHOULD] Defaut Value should be a constant
| ); | ||
|
|
||
| return ( | ||
| <DeviceActionsList title="Keyring Ethereum" deviceActions={deviceActions} /> |
There was a problem hiding this comment.
[MUST] Same here copy paste => Signer Solana
aussedatlo
force-pushed
the
feat/dsdk-554-signer-solana-get-address-usecase
branch
from
e84139a
to
d5d96cb
Compare
aussedatlo
force-pushed
the
feat/dsdk-554-signer-solana-get-address-usecase
branch
from
d5d96cb
to
9a3beab
Compare
mbertin-ledger
approved these changes
Oct 29, 2024
Unlike Ethereum, where the address is derived from the public key, Solana uses the public key directly as the address. To maintain consistency with the Ethereum signer, I’ve retained the |
aussedatlo
force-pushed
the
feat/dsdk-554-signer-solana-get-address-usecase
branch
from
9a3beab
to
c11b4b8
Compare
aussedatlo
deleted the
feat/dsdk-554-signer-solana-get-address-usecase
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add
GetAddressUseCaseimplementation for thesigner-solana.Add signer view in the playground app.
Screen.Recording.2024-10-28.at.14.08.33.mov
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers