Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (keyring-eth) [DSDK-530]: Handle empty arrays with filters #450

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

paoun-ledger
Copy link
Contributor

📝 Description

Full description available in the Jira ticket.
The goal is to correctly handle clear signing of EIP712 messages when an array is empty.
To do that, we should discard filters of all the fields contained in such arrays.

❓ Context

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@paoun-ledger paoun-ledger requested a review from a team as a code owner October 28, 2024 10:50
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:51am

Copy link
Contributor

Messages
Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against 4691efd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant