✨ (keyring-eth) [DSDK-530]: Handle empty arrays with filters #450
+289
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Full description available in the Jira ticket.
The goal is to correctly handle clear signing of EIP712 messages when an array is empty.
To do that, we should discard filters of all the fields contained in such arrays.
❓ Context
JIRA or GitHub link: https://ledgerhq.atlassian.net/browse/DSDK-530
Feature: Fix clear signing of EIP712 messages with an empty array
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers