-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ (signer-solana) [DSDK-552]: Added getAppConfigurationCommand #449
Merged
fAnselmi-Ledger
merged 1 commit into
develop
from
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
Oct 28, 2024
Merged
β¨ (signer-solana) [DSDK-552]: Added getAppConfigurationCommand #449
fAnselmi-Ledger
merged 1 commit into
develop
from
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
fAnselmi-Ledger
force-pushed
the
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
branch
from
October 28, 2024 08:21
4dfba2a
to
50677a9
Compare
fAnselmi-Ledger
changed the title
β¨ (signer-solana) [dsdk-552]: Added getAppConfigurationCommand
β¨ (signer-solana) [DSDK-552]: Added getAppConfigurationCommand
Oct 28, 2024
fAnselmi-Ledger
force-pushed
the
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
branch
from
October 28, 2024 08:33
50677a9
to
80d6dbb
Compare
jdabbech-ledger
approved these changes
Oct 28, 2024
buffer.length !== 5 || | ||
buffer.some((element) => element === undefined) | ||
) { | ||
return CommandResultFactory<GetAppConfigurationCommandResponse>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[could] delete GetAppConfigurationCommandResponse param
valpinkman
approved these changes
Oct 28, 2024
smartine-ledger
approved these changes
Oct 28, 2024
aussedatlo
approved these changes
Oct 28, 2024
fAnselmi-Ledger
force-pushed
the
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
branch
2 times, most recently
from
October 28, 2024 13:39
d0f3656
to
ffd44aa
Compare
fAnselmi-Ledger
force-pushed
the
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
branch
from
October 28, 2024 13:58
ffd44aa
to
73776d5
Compare
fAnselmi-Ledger
force-pushed
the
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
branch
from
October 28, 2024 14:34
73776d5
to
703e661
Compare
fAnselmi-Ledger
force-pushed
the
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
branch
from
October 28, 2024 14:54
703e661
to
9b3da08
Compare
fAnselmi-Ledger
force-pushed
the
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
branch
from
October 28, 2024 15:10
9b3da08
to
a598a71
Compare
fAnselmi-Ledger
deleted the
feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command
branch
October 28, 2024 15:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
Added getAppConfigurationCommand
β Context
β Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
π§ Checklist for the PR Reviewers