Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (signer-solana) [DSDK-552]: Added getAppConfigurationCommand #449

Conversation

fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Oct 28, 2024

πŸ“ Description

Added getAppConfigurationCommand

❓ Context

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner October 28, 2024 08:18
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 28, 2024 3:12pm

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Messages
βœ… Danger: All checks passed successfully! πŸŽ‰

Generated by 🚫 dangerJS against a598a71

@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command branch from 4dfba2a to 50677a9 Compare October 28, 2024 08:21
@fAnselmi-Ledger fAnselmi-Ledger changed the title ✨ (signer-solana) [dsdk-552]: Added getAppConfigurationCommand ✨ (signer-solana) [DSDK-552]: Added getAppConfigurationCommand Oct 28, 2024
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command branch from 50677a9 to 80d6dbb Compare October 28, 2024 08:33
buffer.length !== 5 ||
buffer.some((element) => element === undefined)
) {
return CommandResultFactory<GetAppConfigurationCommandResponse>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[could] delete GetAppConfigurationCommandResponse param

@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command branch 2 times, most recently from d0f3656 to ffd44aa Compare October 28, 2024 13:39
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command branch from ffd44aa to 73776d5 Compare October 28, 2024 13:58
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command branch from 73776d5 to 703e661 Compare October 28, 2024 14:34
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command branch from 703e661 to 9b3da08 Compare October 28, 2024 14:54
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command branch from 9b3da08 to a598a71 Compare October 28, 2024 15:10
@fAnselmi-Ledger fAnselmi-Ledger merged commit 274da94 into develop Oct 28, 2024
9 checks passed
@fAnselmi-Ledger fAnselmi-Ledger deleted the feat/dsdk-552-ts-signer-sol-create-get-app-configuration-command branch October 28, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants