Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init @ledgerhq/crypto-icons library (provider version) #2

Closed
wants to merge 21 commits into from

Conversation

mwiercinska
Copy link
Contributor

@mwiercinska mwiercinska commented Jul 30, 2024

First iteration of the @ledgerhq/crypto-icons library.
LIVE-11698
LIVE-11701

Can be tested locally with pnpm-link or by running pnpm i && pnpm build && pnpm pack and then pointing to the package location in a consumer's package.json e.g.
"@ledgerhq/crypto-icons": "file:../crypto-icons/lib/ledgerhq-crypto-icons-1.0.0.tgz"

The following will be in follow-up PRs:

  • Update COINGECKO_MAPPED_ASSETS_URL to prod url
  • Deploying Storybook (+ re-deploy on asset change)
  • Build and publish workflow
  • Additional testing
  • README

Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2024

Deploying crypto-icons with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6ca74e6
Status: ✅  Deploy successful!
Preview URL: https://401ad1d0.crypto-icons.pages.dev
Branch Preview URL: https://live-11698-create-ledgerhq-c.crypto-icons.pages.dev

View logs

Copy link

socket-security bot commented Jul 30, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node -e "try{require('./config/scripts/postinstall')}catch(e){}"
🚫
Install scripts npm/@swc/[email protected]
  • Install script: postinstall
  • Source: node postinstall.js
🚫
Install scripts npm/[email protected] 🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

@beths-ledger beths-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some interim comments - also covered in slack to make back and forth a bit easier!

crypto-icons/.eslintignore Outdated Show resolved Hide resolved
crypto-icons/src/components/CryptoIcon/CryptoIcon.types.ts Outdated Show resolved Hide resolved
crypto-icons/src/components/CryptoIcon/CryptoIcon.types.ts Outdated Show resolved Hide resolved
crypto-icons/src/hooks/useCryptoIcons.ts Outdated Show resolved Hide resolved
crypto-icons/src/components/FallbackIcon/FallbackIcon.tsx Outdated Show resolved Hide resolved
@mwiercinska mwiercinska marked this pull request as ready for review August 1, 2024 09:35
Copy link
Collaborator

@sarneijim sarneijim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I think that we can improve few details.

lib/package.json Outdated Show resolved Hide resolved
lib/package.json Outdated Show resolved Hide resolved
lib/src/components/CryptoIcon/CryptoIcon.test.tsx Outdated Show resolved Hide resolved
lib/src/hooks/useCryptoIcons.ts Outdated Show resolved Hide resolved
lib/src/hooks/useCryptoIcons.ts Outdated Show resolved Hide resolved
@mwiercinska mwiercinska changed the title feat: init crypto-icons library feat: init @ledgerhq/crypto-icons library Aug 1, 2024
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, network +5 2.42 MB jasonsaayman
npm/[email protected] environment, filesystem, unsafe 0 7.7 MB prettier-bot
npm/[email protected] None 0 21.9 MB typescript-bot

View full report↗︎

@mwiercinska mwiercinska changed the title feat: init @ledgerhq/crypto-icons library feat: init @ledgerhq/crypto-icons library (provider version) Aug 5, 2024
@mwiercinska mwiercinska marked this pull request as draft August 5, 2024 15:32
@mwiercinska mwiercinska marked this pull request as ready for review August 6, 2024 08:23
@mwiercinska mwiercinska closed this Aug 6, 2024
@mwiercinska mwiercinska deleted the LIVE-11698-create-ledgerhq-crypto-icons branch August 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants