Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for musig() key expressions #230

Closed
wants to merge 24 commits into from
Closed

Add support for musig() key expressions #230

wants to merge 24 commits into from

Commits on Jul 16, 2024

  1. Added parsing for musig(); generalized key placeholders in wallet pol… 

    …icies to more general key expressions
    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7f65a9a View commit details
    Browse the repository at this point in the history

  2. Rename "key placeholder" with "key expression" where appropriate; add… 

    …ed some comments.

Generalizing to key expressions containing musig() makes it necessary to distinguish
the key expressions in the wallet policy from the actual key placeholders that are
just indexes to the list of key informations (@num in the descriptor template),
whereas the two concepts were often not clearly separated in the code base.

Renaming to "key expressions" makes the distinction more clear.
    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    878c320 View commit details
    Browse the repository at this point in the history

  3. Refactored policy_node_keyexpr_t to explicitly label which of the uni… 

    …on type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.
    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d987161 View commit details
    Browse the repository at this point in the history

  4. Add PSBT constants related to MuSig2; deleted unused constant

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    957fc42 View commit details
    Browse the repository at this point in the history

  5. Moved secp256k1 constants to a separate module

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3e7478d View commit details
    Browse the repository at this point in the history

  6. Added address generation tests for musig

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    717e95a View commit details
    Browse the repository at this point in the history

  7. Made crypto_tr_lift_x and crypto_tr_tagged_hash functions public

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a4076ae View commit details
    Browse the repository at this point in the history

  8. Musig key aggregation and address generation

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9264207 View commit details
    Browse the repository at this point in the history

  9. Compute aggregate xpub for musig() in descriptors in the python clien… 

    …t library
    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    04e9a8d View commit details
    Browse the repository at this point in the history

  10. Add musig2 fields to PSBT class

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9e7a003 View commit details
    Browse the repository at this point in the history

  11. Added python standalone implementation of MuSig2 signing, and tests

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    287418f View commit details
    Browse the repository at this point in the history

  12. Add 'tweak' output parameter to bip32_CKDpub; exposed BIP341 constants

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dd45e06 View commit details
    Browse the repository at this point in the history

  13. Add parsing of Musig2 pubnonces and partial signatures as yielded val… 

    …ues in sign_psbt in the python client
    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    cd81210 View commit details
    Browse the repository at this point in the history

  14. MuSig2 signing, rounds 1 and 2

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5625de5 View commit details
    Browse the repository at this point in the history

  15. Update musig() specs, and fix psbt processing 

     - musig() now sorts the keys, as per the BIP draft
 - correctly compute fingerprint for musig() aggregate key
 - added both the aggregate and the internal key in keyexpr_info_t struct
 - fixed psbt parsing logic to detect change/addr_index for musig
 - updated musig tests
    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    92bb506 View commit details
    Browse the repository at this point in the history

  16. Fix psbt-level musig signing session logic

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9d27038 View commit details
    Browse the repository at this point in the history

  17. Modularize and extract the musig session handling from sign_psbt.c

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e947e37 View commit details
    Browse the repository at this point in the history

  18. Persistent storage for musig psbt signing sessions

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3d5a4d9 View commit details
    Browse the repository at this point in the history

  19. Add ragger navigation to musig sign_psbt tests

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1c6a4a8 View commit details
    Browse the repository at this point in the history

  20. Update sanity checks for musig key expressions

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f52aef2 View commit details
    Browse the repository at this point in the history

  21. Add architecture docs for MuSig2

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7bc384d View commit details
    Browse the repository at this point in the history

  22. Reference musig docs in musig session module

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9add438 View commit details
    Browse the repository at this point in the history

  23. Add const qualifiers, and asserts guarding against overflows

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d18d0db View commit details
    Browse the repository at this point in the history

  24. Expose new types in python client

    @bigspider
    bigspider committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    dc99225 View commit details
    Browse the repository at this point in the history