Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗞️ Solana: Add OmniCounter Example [1/N] #872

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

St0rmBr3w
Copy link
Contributor

@St0rmBr3w St0rmBr3w commented Aug 27, 2024

In this PR

Added: A Solana OmniCounter example.

Current Issues:

  • Outdated method identifiers (e.g., setRemote instead of setPeer).
  • Lacks unit tests; currently serves as a dummy implementation.
  • Built to work with an outdated example (OmniCounter was originally part of the OZ4 changeset, not OZ5), requiring adjustments.
  • Missing feature parity with EVM; does not support ABA or Composed ABA.

Deployment Status:

  • Deployment has not been tested yet; this implementation is based on the Hong Kong team's work.

Request for Feedback:

  • Should we continue developing and refining this example?
  • Or, should we discard this approach and build an OApp example from scratch to better align with the base OApp Standard?

Copy link

socket-security bot commented Aug 27, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] environment, filesystem, unsafe Transitive: network, shell +40 11.3 MB nicolo-ribaudo
npm/@changesets/[email protected] environment, filesystem, shell Transitive: eval, unsafe +103 15.1 MB changesets-release-bot
npm/@layerzerolabs/[email protected] None 0 2.56 MB layerzero-bot
npm/@layerzerolabs/[email protected] environment Transitive: eval +68 3.23 MB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: environment, filesystem, network, shell, unsafe +184 43.3 MB layerzero-bot
npm/@layerzerolabs/[email protected] None +1 703 kB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: environment, eval, filesystem, network +194 23.8 MB layerzero-bot
npm/@layerzerolabs/[email protected] None +1 983 kB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: environment, eval, filesystem, network +144 5.04 MB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: environment, eval, filesystem, network +144 4.8 MB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: environment, eval, filesystem, shell +117 17.2 MB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: network +39 2.55 MB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 5.37 MB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: network +2 5.49 MB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 451 kB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 12.8 kB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 6.79 kB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 400 kB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: environment, filesystem +32 726 kB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: eval +68 3.34 MB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 7.01 kB layerzero-bot
npm/@layerzerolabs/[email protected] None +1 1.34 MB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 179 kB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 27.8 kB layerzero-bot
npm/@layerzerolabs/[email protected] None +2 1.15 MB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 861 kB layerzero-bot
npm/@layerzerolabs/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +594 404 MB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +9 6.74 MB layerzero-bot
npm/@layerzerolabs/[email protected] None 0 6 kB layerzero-bot
npm/@layerzerolabs/[email protected] Transitive: eval +68 3.25 MB layerzero-bot
npm/@nomicfoundation/[email protected] Transitive: environment, filesystem, network +62 38.8 MB kanej
npm/@openzeppelin/[email protected] None 0 2.11 MB amxx
npm/@openzeppelin/[email protected] None 0 2.02 MB frangio
npm/@solana/[email protected] network Transitive: environment, filesystem, shell +42 16.3 MB lorisleiva
npm/@swc/[email protected] environment, filesystem, shell +14 443 MB kdy1
npm/@types/[email protected] None 0 82.2 kB types
npm/@types/[email protected] None 0 95.9 kB types
npm/@types/[email protected] None +3 1.43 MB types
npm/@types/[email protected] None 0 6.97 kB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +38 7.75 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +32 2.9 MB jameshenry
npm/[email protected] environment, filesystem, unsafe Transitive: eval +92 5.83 MB ljharb
npm/[email protected] filesystem Transitive: environment, network +184 9.31 MB mattphillips
npm/[email protected] Transitive: environment +4 160 kB jounqin
npm/[email protected] None 0 72.5 kB eslint-community-bot
npm/[email protected] environment 0 118 kB react-bot
npm/[email protected] filesystem Transitive: environment, eval +323 17.7 MB ljharb
npm/[email protected] environment, eval, filesystem, shell +1 490 kB turbobot
npm/[email protected] None 0 1.3 MB ndubien
npm/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +578 182 MB kanej
npm/[email protected] Transitive: environment, filesystem, shell +50 2.04 MB okonet
npm/[email protected] environment, eval, filesystem Transitive: network +138 6.53 MB voxpelli
npm/[email protected] Transitive: unsafe +1 7.2 MB janther
npm/[email protected] environment, filesystem, unsafe 0 7.7 MB prettier-bot
npm/[email protected] environment, filesystem Transitive: shell +22 1.83 MB isaacs
npm/[email protected] Transitive: environment, eval +8 7.19 MB fatso83
npm/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +187 41.5 MB diego.bale.arg
npm/[email protected] environment, filesystem, network, shell +31 913 kB nake89
npm/[email protected] environment Transitive: filesystem, unsafe +9 1.13 MB piotrwitek
npm/[email protected] environment, eval, filesystem Transitive: shell, unsafe +938 300 MB egoist
npm/[email protected] eval, filesystem Transitive: environment, network, shell, unsafe +121 249 MB egoist
npm/[email protected] environment, filesystem, network, shell, unsafe +4 3.18 MB google-wombot

🚮 Removed packages: npm/@babel/[email protected]), npm/@changesets/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@layerzerolabs/[email protected]), npm/@nomicfoundation/[email protected]), npm/@openzeppelin/[email protected]), npm/@openzeppelin/[email protected]), npm/@rushstack/[email protected]), npm/@solana/[email protected]), npm/@swc/[email protected]), npm/@types/[email protected]), npm/@types/[email protected]), npm/@types/[email protected]), npm/@types/[email protected]), npm/@typescript-eslint/[email protected]), npm/@typescript-eslint/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected]), npm/[email protected])

View full report↗︎

@St0rmBr3w St0rmBr3w changed the title feat: Add Solana OmniCounter Example 🗞️ Solana: Add OmniCounter Example Aug 27, 2024
@St0rmBr3w St0rmBr3w changed the title 🗞️ Solana: Add OmniCounter Example 🗞️ Solana: Add OmniCounter Example [1/N] Aug 27, 2024
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Protestware/Troll package npm/[email protected]
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
⚠︎

View full report↗︎

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package may come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@janjakubnanista
Copy link
Contributor

@St0rmBr3w do you still want this merged? Could you update and resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants