Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(oft-solana): explain required versions for Solana CLI and mention priority fees #1074

Merged
merged 3 commits into from
Nov 24, 2024
Merged

docs(oft-solana): explain required versions for Solana CLI and mention priority fees #1074

merged 3 commits into from
Nov 24, 2024

Conversation

nazreen
Copy link
Contributor

@nazreen nazreen commented Nov 23, 2024

Changes

  • removed link to official solana.com installation guide as that will lead to installing Solana CLI v2 which we don't yet support.
  • instead, list directly instructions to install Rust, Solana, Anchor.
  • explainer on priority fees
  • provide command to deploy with priority fees

Not yet included:

  • how to estimate priority fees

St0rmBr3w
St0rmBr3w requested changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@St0rmBr3w St0rmBr3w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, overall looks great, thanks @nazreen!

examples/oft-solana/README.md Outdated Show resolved Hide resolved
@nazreen
Copy link
Contributor Author

nazreen commented Nov 24, 2024

@St0rmBr3w your requested change was done. Ready for re-review!

@St0rmBr3w St0rmBr3w merged commit 00ed37f into main Nov 24, 2024
7 checks passed
@St0rmBr3w St0rmBr3w deleted the nazreen/solana-versioning branch November 24, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@St0rmBr3w St0rmBr3w St0rmBr3w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nazreen @St0rmBr3w