-
Notifications
You must be signed in to change notification settings - Fork 1
P2P - Part 3 #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: p2p-part-2
Are you sure you want to change the base?
P2P - Part 3 #1107
Conversation
2f69f2f to
554f2e1
Compare
ueco-jb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
One other thing that is puzzling me a little is using a DefaultHasher, IIRC it was not advised to be actually used in distributed networks (or maybe I'm overdramatizing).
https://doc.rust-lang.org/src/std/hash/random.rs.html#99-104
I'm thinking about a hypothetical case where we do a partial upgrade of the network and some of the nodes are running a different (although compatible) version. But even in the worst case that would only increase an amount of duplicated (ignored) messages.
idk, but it's what they use in their example, so I assume it's fine for our purposes: https://github.com/libp2p/rust-libp2p/blob/5e3519fb66b92c7f7c0dc744ab360fd8b669fe54/examples/chat/src/main.rs#L62 |
Builds on top of #1106
Followed by #1108
Adds local p2p dev setup with mDNS and completes the e2e test setup to prove that it works