exclude terminator registers for ecotop #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LavermanJJ
reviewed
Feb 26, 2024
| # assuming octoplus is also related to Therminator | ||
| self.octoplus_buffer_temperature_bottom = DataValue(address=10, multiplier=0.1) | ||
| self.octoplus_buffer_temperature_top = DataValue(address=11, multiplier=0.1) | ||
| self.log_wood = DataValue(address=12, data_type=DataTypes.UINT) |
There was a problem hiding this comment.
According to the logs, it was only the "log_wood" property that is unavailable for pellettops, isn't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if some registers are not available on the system, but read, this leads to errors in the home assistant integration
unfortunately we don't have a comprehensive overview from solarfocus of all devices and the related (working) registers
just excluded the registers that are not used by ecotop (as of my knowledge)
related to #31