Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address #57, use mob heads instead of spawn eggs #129

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

Address #57, use mob heads instead of spawn eggs #129

wants to merge 1 commit into from

Conversation

Aurelien30000
Copy link
Member

@Aurelien30000 Aurelien30000 commented Aug 17, 2022 •
edited
Loading

Closes #57

@Aurelien30000 Aurelien30000 added enhancement New feature or request size: small labels Aug 17, 2022
@SirYwell
Copy link
Member

I think this would be a good candidate for a more data-driven approach. Maybe we can extract all the texture strings in some kind of file? In best case, this would also be independent from Bukkit or WorldEdit/WorldGuard.

@Aurelien30000
Copy link
Member Author

From a json file it would fit smoothly imo. Making it independent from any API is okay, but we need WE/Bukkit to show them as items 😅

@SirYwell
Copy link
Member

but we need WE/Bukkit to show them as items

Yes, we can have adapters for it, but the API should be separate.

@Aurelien30000 Aurelien30000 marked this pull request as draft September 17, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainbowdashlabs rainbowdashlabs Awaiting requested review from rainbowdashlabs

@SirYwell SirYwell Awaiting requested review from SirYwell

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request size: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement: change mob eggs to heads.
2 participants
@Aurelien30000 @SirYwell