-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate all packages from dev.onyxstudios
to org.ladysnake
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update documentation and licenses to reflect package change
Updated in GitHub editor because I could not change it locally.
Great work, though I probably won't merge this soon due to the obvious breaking changes. |
# Conflicts: # cardinal-components-base/src/main/java/org/ladysnake/cca/api/v3/component/ComponentKey.java # cardinal-components-base/src/main/java/org/ladysnake/cca/api/v3/component/ComponentProvider.java # cardinal-components-base/src/main/java/org/ladysnake/cca/internal/base/asm/CcaClientInternals.java # cardinal-components-base/src/main/java/org/ladysnake/cca/internal/base/asm/ComponentUpdatePayload.java # cardinal-components-base/src/main/java/org/ladysnake/cca/internal/base/asm/MorePacketCodecs.java # cardinal-components-block/src/main/java/org/ladysnake/cca/internal/BlockEntityAddress.java # cardinal-components-block/src/main/java/org/ladysnake/cca/internal/CardinalComponentsBlock.java # cardinal-components-block/src/main/java/org/ladysnake/cca/internal/CcaBlockClient.java # cardinal-components-block/src/main/java/org/ladysnake/cca/mixin/block/common/MixinBlockEntity.java # cardinal-components-chunk/src/main/java/org/ladysnake/cca/internal/chunk/CardinalComponentsChunk.java # cardinal-components-chunk/src/main/java/org/ladysnake/cca/internal/chunk/CcaChunkClient.java # cardinal-components-chunk/src/main/java/org/ladysnake/cca/internal/chunk/CcaLevelUpdatePayload.java # cardinal-components-chunk/src/main/java/org/ladysnake/cca/mixin/chunk/common/MixinWorldChunk.java # cardinal-components-entity/src/main/java/org/ladysnake/cca/internal/entity/CardinalComponentsEntity.java # cardinal-components-entity/src/main/java/org/ladysnake/cca/internal/entity/CcaEntityClient.java # cardinal-components-entity/src/main/java/org/ladysnake/cca/mixin/entity/common/MixinEntity.java # cardinal-components-level/src/main/java/org/ladysnake/cca/internal/level/CardinalComponentsLevel.java # cardinal-components-level/src/main/java/org/ladysnake/cca/internal/level/CcaLevelClient.java # cardinal-components-level/src/main/java/org/ladysnake/cca/mixin/level/common/MixinLevelProperties.java # cardinal-components-scoreboard/src/main/java/org/ladysnake/cca/internal/scoreboard/CardinalComponentsScoreboard.java # cardinal-components-scoreboard/src/main/java/org/ladysnake/cca/internal/scoreboard/CcaScoreboardClient.java # cardinal-components-scoreboard/src/main/java/org/ladysnake/cca/mixin/scoreboard/MixinServerScoreboard.java # cardinal-components-scoreboard/src/main/java/org/ladysnake/cca/mixin/scoreboard/MixinTeam.java # cardinal-components-world/src/main/java/org/ladysnake/cca/internal/world/CardinalComponentsWorld.java # cardinal-components-world/src/main/java/org/ladysnake/cca/internal/world/CcaWorldClient.java # cardinal-components-world/src/main/java/org/ladysnake/cca/mixin/world/common/MixinServerWorld.java # src/testmod/java/org/ladysnake/componenttest/content/vita/ItemVita.java
Pyrofab
reviewed
Feb 4, 2024
Pyrofab
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the side cleanup, quite appreciated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR acts as a base to a potential
v6
update as per this discussion. Note: currently based on the1.20
branch, but should be merged into a newv6
branch once one has been created.