Add experimental client-to-server component messaging API #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cardinal-components-entity/src/main/java/org/ladysnake/cca/api/v3/entity/C2SSelfMessagingComponent.java # cardinal-components-entity/src/main/java/org/ladysnake/cca/internal/entity/CardinalComponentsEntity.java # cardinal-components-entity/src/main/java/org/ladysnake/cca/mixin/entity/common/MixinEntity.java # src/testmod/java/org/ladysnake/componenttest/content/vita/sync/C2SComponentPacketWriter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many instances, a mod that implements synced components also needs to send back messages to the server to affect the state of said components - typically in reaction to a key press or to a GUI click.
This PR aims to simplify those interactions by removing the need to create and register a custom packet type. As most use cases apply to a player component sending a message to itself, the new
C2SSelfMessagingComponentinterface is tailored for that. Future improvements may include a more generic component Client-To-Server messaging API, which is whyC2SComponentPacketWriterwas made part of the base module.