Appkit+Qt+LibWeb+LibWebView: Dock inspector in browser window #1438
+370
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
neil-ptr
force-pushed
the
docked-inspector
branch
from
97596dc
to
a17bf83
Compare
added 6 commits
September 19, 2024 00:27
neil-ptr
force-pushed
the
docked-inspector
branch
2 times, most recently
from
8396da1
to
ccfabe3
Compare
neil-ptr
force-pushed
the
docked-inspector
branch
from
ccfabe3
to
a8f134d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows for the inspector to be docked in the window beside the web content. There are some issues with the
<select/>tag dropdowns that are within the inspector but didn't address them as they were out of scope for this feature.This PR also sets the ground work to have up, down, left, right and windowed inspector positions in a
<select/>within the inspector and also have the browser remember what the last size and position that inspector was in last which I hope to follow up this PR withAppkit
VideoSmaller.Sept.19.Screen.Recording.mov
Qt
VideoSmaller.Screen.Recording.Sept.19.mov