Meta: Allow ladybird.sh to run any target in the MacOS app bundle
#1436
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADKaster
reviewed
Sep 19, 2024
tcl3
force-pushed
the
meta_ladybird_lagom_target_macos
branch
from
b4d833f
to
440e236
Compare
tcl3
changed the title
ladybird.sh to run any lagom target on MacOSladybird.sh to run any target in the MacOS app bundle
tcl3
force-pushed
the
meta_ladybird_lagom_target_macos
branch
from
440e236
to
87529f0
Compare
ADKaster
approved these changes
Sep 19, 2024
Previously, using `ladybird.sh run` with any target that was part of the MacOS app bundle would try to run the given executable from the wrong directory.
tcl3
force-pushed
the
meta_ladybird_lagom_target_macos
branch
from
87529f0
to
16b7aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using
ladybird.sh runwith any target that was part of the MacOS app bundle would try to run the given executable from the wrong directory.