LibWeb: Implement Range's extension method #1417
Conversation
An-n-ya
force-pushed
the
range-client-rects
branch
from
a5789c0
to
4439cf5
Compare
Tests/LibWeb/Text/input/DOM/range-bounding-client-rect-with-nested-text.html
Outdated
Show resolved
Hide resolved
An-n-ya
force-pushed
the
range-client-rects
branch
from
4439cf5
to
fd52dea
Compare
There was a problem hiding this comment.
I am testing the branch locally and found that it breaks selection on pages where it used to work. you can reproduce the problem by trying to select a text using mouse on a page as simple as <p>Hello</p>.
Besides that issue the change seems good and thank you for making progress on it!
This patch implements `Range::getClientRects` and `Range::getBoundingClientRect`. Since the rects returned by invoking getClientRects can be accessed without adding them to the Selection, `ViewportPaintable::recompute_selection_states` has been updated to accept a Range as a parameter, rather than acquiring it through the Document's Selection. With this change, the following tests now pass: - wpt[css/cssom-view/range-bounding-client-rect-with-nested-text.html] - wpt[css/cssom-view/DOMRectList.html] Note: The test "css/cssom-view/range-bounding-client-rect-with-display-contents.html" still fails due to an issue with Element::getClientRects, which will be addressed in a future commit.
An-n-ya
force-pushed
the
range-client-rects
branch
from
fd52dea
to
1277aca
Compare
| // 3. Mark the nodes included in range selected. | ||
| for (auto* node = start_container; node && node != end_container->next_in_pre_order(); node = node->next_in_pre_order()) { | ||
| if (auto* paintable = node->paintable()) | ||
| paintable->set_selected(true); | ||
| } | ||
| } |
There was a problem hiding this comment.
I am testing the branch locally and found that it breaks selection on pages where it used to work. you can reproduce the problem by trying to select a text using mouse on a page as simple as
<p>Hello</p>.Besides that issue the change seems good and thank you for making progress on it!
The problem is caused by incorrectly iterating over the range's included nodes, which is addressed here.
kalenikaliaksandr
merged commit 75c7dbc
into
LadybirdBrowser:master
This patch implements
Range::getClientRectsandRange::getBoundingClientRect. Since the rects returned by invoking getClientRects can be accessed without adding them to the Selection,ViewportPaintable::recompute_selection_stateshas been updated to accept a Range as a parameter, rather than acquiring it through the Document's Selection.With this change, the following tests now pass:
Note: The test range-bounding-client-rect-with-display-contents still fails due to an issue with
Element::getClientRects, which will be addressed in a future commit.