-
-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb: rename 'cross-origin opener policy' to 'opener policy' #1399
Conversation
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
f6008c3
to
1d90a29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
I've marked a few places where your changes don't quite match the spec text. We're quite fussy about that. :^)
Also in two places the spec still says "cross-origin opener policy". That seems to be a mistake in the spec so while I've noted them, you can ignore them. I've opened whatwg/html#10631 to fix the spec.
When making corrections, please make the changes to your existing commit. This video is good at explaining how to do that in case you're not super familiar with git. You can also ask here or on Discord if you get confused.
Userland/Libraries/LibWeb/HTML/CrossOrigin/OpenerPolicyEnforcementResult.h
Show resolved
Hide resolved
1d90a29
to
99e7a22
Compare
Thank you for the feedback. I could have done it easier by just copying the spec text. Should al be corrected now. |
99e7a22
to
d17fe78
Compare
455c94b
to
4a7bb79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks again. :^)
Happy to be able to contribute! Thanks for the help. |
Closes #1387