Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: rename 'cross-origin opener policy' to 'opener policy' #1399

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

0xkon1
Copy link

@0xkon1 0xkon1 commented Sep 14, 2024

Closes #1387

@ladybird-bot
Copy link
Collaborator

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@0xkon1 0xkon1 force-pushed the opener_policy branch 2 times, most recently from f6008c3 to 1d90a29 Compare September 14, 2024 14:44
Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

I've marked a few places where your changes don't quite match the spec text. We're quite fussy about that. :^)

Also in two places the spec still says "cross-origin opener policy". That seems to be a mistake in the spec so while I've noted them, you can ignore them. I've opened whatwg/html#10631 to fix the spec.

When making corrections, please make the changes to your existing commit. This video is good at explaining how to do that in case you're not super familiar with git. You can also ask here or on Discord if you get confused.

Userland/Libraries/LibWeb/HTML/CrossOrigin/OpenerPolicy.h Outdated Show resolved Hide resolved
Userland/Libraries/LibWeb/HTML/CrossOrigin/OpenerPolicy.h Outdated Show resolved Hide resolved
Userland/Libraries/LibWeb/HTML/Navigable.cpp Show resolved Hide resolved
Userland/Libraries/LibWeb/HTML/Navigable.cpp Outdated Show resolved Hide resolved
Userland/Libraries/LibWeb/HTML/Navigable.cpp Outdated Show resolved Hide resolved
Userland/Libraries/LibWeb/HTML/Navigable.cpp Show resolved Hide resolved
Userland/Libraries/LibWeb/HTML/NavigationParams.h Outdated Show resolved Hide resolved
Userland/Libraries/LibWeb/HTML/NavigationParams.h Outdated Show resolved Hide resolved
@0xkon1
Copy link
Author

0xkon1 commented Sep 18, 2024

Thank you for the feedback. I could have done it easier by just copying the spec text. Should al be corrected now.

Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again. :^)

@AtkinsSJ AtkinsSJ merged commit de31ea5 into LadybirdBrowser:master Sep 24, 2024
5 of 6 checks passed
@0xkon1
Copy link
Author

0xkon1 commented Sep 24, 2024

Happy to be able to contribute! Thanks for the help.

@0xkon1 0xkon1 deleted the opener_policy branch September 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "cross-origin opener policy" to "opener policy"
3 participants