Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "cross-origin opener policy" to "opener policy" #1387

Closed
AtkinsSJ opened this issue Sep 13, 2024 · 3 comments · Fixed by #1399
Closed

Rename "cross-origin opener policy" to "opener policy" #1387

AtkinsSJ opened this issue Sep 13, 2024 · 3 comments · Fixed by #1399
Labels
good first issue Good for newcomers

Comments

@AtkinsSJ
Copy link
Member

As changed here: whatwg/html#10579

As well as renaming our CrossOriginOpenerPolicy, we'll need to update any spec comments that refer to it. That'll involve a lot of looking through the changes in that PR, finding where we implement that part of the spec, and changing the text.
@AtkinsSJ AtkinsSJ added the good first issue Good for newcomers label Sep 13, 2024
@0xkon1
Copy link

0xkon1 commented Sep 14, 2024

Is this issue still up for grabs?

@AtkinsSJ
Copy link
Member Author

Sure! Go ahead. :^)

@0xkon1 0xkon1 mentioned this issue Sep 14, 2024
Merged
@0xkon1
Copy link

0xkon1 commented Sep 15, 2024

I hope this was what is asked for. Almost forgot to change the comments tho. I looked at the links too, but seems like they haven't been updated and the old links point to the current spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LibWeb: rename 'cross-origin opener policy' to 'opener policy' 0xkon1/ladybird
2 participants
@AtkinsSJ @0xkon1