Skip to content
This repository has been archived by the owner on Dec 25, 2022. It is now read-only.

Introduce meta checks #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

faxe1008
Copy link

This PR adds the bare minimum of Meta checks that I saw fit, making local dev a bit more comfy as issues are caught before commiting :^)

Copy link
Contributor

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the modifications here, and how will we keep them in sync?

@ADKaster
Copy link
Member

This also doesn't add an actions pipeline to actually enforce these checks :)

@faxe1008
Copy link
Author

What are the modifications here, and how will we keep them in sync?

Removing the SerenityOS specific checks, e.g. paths and exceptions. At the moment changes need to be synced manually. I do not know if there is a better way of doing it.

This also doesn't add an actions pipeline to actually enforce these checks :)

I have not worked with github actions beforehand, I wanted to place this PR first before messing around with github workflows. :^) The goal of this PR atm is to catch the issues when developing locally.

This patch adds a modified copy of the Serenity repo style checking
scripts.
This patch adds a basic pre-commit configuration.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants