Add Mongoid support with shared Core modules by Copilot · Pull Request #908 · LTe/acts-as-messageable

Copilot · 2026-01-31T10:27:21Z

Refactoring Mongoid support to reduce code duplication

Changes Made

Created shared Core modules with ORM-agnostic behavior
Refactored Mongoid implementation to use mongoid-tree gem
Added Sorbet type signatures to all modules
Merged spec helpers into single file with MONGOID_SPECS=true flag
Extracted shared test examples to spec/support/shared_examples.rb
Extracted shared ClassBehavior (lib/acts_as_messageable/core/class_behavior.rb)
Added GitHub Action for Mongoid specs - test-mongoid job with MongoDB service
Refactored tree structure tests - Tests now use send_message, reply_to instead of low-level parent assignment
Verify all tests pass (115 examples, 0 failures)

Tree Structure Tests (Revised)

describe 'tree structure (ancestry)' do
  it 'message without parent is its own root'
  it 'reply has original message as root'
  it 'nested reply has original message as root'
  it 'subtree includes all messages in conversation thread'
  it 'conversation returns messages in correct order (newest first)'
end

Original prompt

This section details on the original issue you should resolve

<issue_title>Could you offer a version using Mongoid?</issue_title>
<issue_description></issue_description>

<agent_instructions>@copilot Can you add support for Mongoid?</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@LTe I am open to pull requests which provide Mongoid supports

Fixes Could you offer a version using Mongoid? #59

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

LTe · 2026-01-31T11:26:20Z

spec/mongoid_spec.rb

@@ -0,0 +1,369 @@
+# typed: false


Specs in this file looks almost the same as in other file. I think we should have the same specs for both ActiveRecord and Monogoid and change only setup / teardown if needed.

@copilot can you fix that?

Refactored to use shared examples in spec/support/shared_examples.rb. Both ActiveRecord and Mongoid specs now include the same test cases via include_examples 'acts_as_messageable', adapter: :active_record/:mongoid, with only ORM-specific setup/teardown and adapter-specific tests in individual spec files. (b0f9b39)

This was addressed in b0f9b39. The specs now use shared examples in spec/support/shared_examples.rb that both acts_as_messageable_spec.rb and mongoid_spec.rb include via include_examples 'acts_as_messageable', adapter: :active_record/:mongoid. Only ORM-specific tests remain in individual spec files.

Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

LTe · 2026-01-31T20:27:08Z

spec/mongoid_spec.rb

+  describe 'ancestry functionality' do
+    let(:message) { ActsAsMessageable::Mongoid::Message.create!(topic: 'topic', body: 'body') }
+
+    it 'returns root of the conversation' do
+      expect(message.conversation).to include(message)
+    end
+
+    it 'handles parent assignment' do
+      parent_message = ActsAsMessageable::Mongoid::Message.create!(topic: 'parent', body: 'parent body')
+      child_message = ActsAsMessageable::Mongoid::Message.create!(topic: 'child', body: 'child body')
+      child_message.parent = parent_message
+      child_message.save!
+
+      expect(child_message.parent).to eq(parent_message)
+      expect(child_message.root).to eq(parent_message)
+    end
+
+    it 'handles subtree' do
+      parent_message = ActsAsMessageable::Mongoid::Message.create!(topic: 'parent', body: 'parent body')
+      child_message = ActsAsMessageable::Mongoid::Message.create!(topic: 'child', body: 'child body')
+      child_message.parent = parent_message
+      child_message.save!
+
+      expect(parent_message.subtree.to_a).to include(parent_message, child_message)
+    end
+  end


This is to specific, it should be tested between adapters and should be in shared behavior. We are testing gem here that provide tree structure.

Moved tree structure tests to shared examples in spec/support/shared_examples.rb. The tests now run for both ActiveRecord and Mongoid adapters. (ae040cb)

LTe · 2026-01-31T20:27:45Z

spec/spec_helper.rb

+MONGOID_SPECS_ENABLED = ENV['MONGOID_SPECS'] == 'true'
+
+if MONGOID_SPECS_ENABLED
+  require 'mongoid'
+  require 'acts_as_messageable/mongoid'
+
+  # Configure Mongoid for testing
+  Mongoid.configure do |config|
+    config.clients.default = {
+      hosts: [ENV.fetch('MONGODB_HOST', 'localhost:27017')],
+      database: 'acts_as_messageable_test'
+    }
+    config.log_level = :warn
+  end
+
+  # Include Mongoid model support
+  Mongoid::Document::ClassMethods.include ActsAsMessageable::Mongoid::Model
+  Mongoid::Criteria.include ActsAsMessageable::Mongoid::Relation
+
+  # Load Mongoid test models
+  require_relative 'support/mongoid_models'
+end


Do we have github action that will run this?

Added test-mongoid job to .github/workflows/test.yml that runs Mongoid specs with a MongoDB service container. (ae040cb)

LTe · 2026-01-31T20:28:13Z

lib/acts_as_messageable/mongoid/model.rb

+          default_options = {
+            class_name: 'ActsAsMessageable::Mongoid::Message',
+            required: %i[topic body],
+            dependent: :nullify,
+            group_messages: false,
+            search_scope: :search
+          }
+          options = default_options.merge(options)
+
+          cattr_accessor(:messages_class_name, :group_messages)
+
+          has_many :received_messages_relation,
+                   as: :received_messageable,
+                   class_name: options[:class_name],
+                   dependent: options[:dependent]
+          has_many :sent_messages_relation,
+                   as: :sent_messageable,
+                   class_name: options[:class_name],
+                   dependent: options[:dependent]
+
+          self.messages_class_name = options[:class_name].constantize
+          messages_class_name.initialize_scopes(options[:search_scope])
+
+          messages_class_name.required = Array.wrap(options[:required])
+          messages_class_name.required.each do |attr|
+            messages_class_name.validates attr, presence: true
+          end
+          self.group_messages = options[:group_messages]


This part is almost identical to Active Record. Try harder with refactoring.

Extracted shared ClassBehavior module in lib/acts_as_messageable/core/class_behavior.rb. The acts_as_messageable method now uses shared setup_messageable logic with adapter-specific messageable_default_options and define_messageable_associations methods. (ae040cb)

…mples, add Mongoid CI job Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

LTe · 2026-01-31T20:37:21Z

spec/support/shared_examples.rb

+  describe 'tree structure (ancestry)' do
+    let(:message_class) { adapter == :mongoid ? ActsAsMessageable::Mongoid::Message : ActsAsMessageable::Message }
+
+    before do
+      if adapter == :active_record
+        # Use clean version of Message class
+        ActsAsMessageable::Message.table_name = 'messages'
+        ActsAsMessageable::Message.required = []
+        ActsAsMessageable::Message.clear_validators! if ActsAsMessageable::Message.respond_to?(:clear_validators!)
+      end
+    end
+
+    it 'returns root of the conversation' do
+      test_message = message_class.create!(topic: 'topic', body: 'body')
+      expect(test_message.conversation).to include(test_message)
+    end
+
+    it 'handles parent assignment' do
+      parent_message = message_class.create!(topic: 'parent', body: 'parent body')
+      child_message = message_class.create!(topic: 'child', body: 'child body')
+      child_message.parent = parent_message
+      child_message.save!
+
+      expect(child_message.parent).to eq(parent_message)
+      expect(child_message.root).to eq(parent_message)
+    end
+
+    it 'handles subtree' do
+      parent_message = message_class.create!(topic: 'parent', body: 'parent body')
+      child_message = message_class.create!(topic: 'child', body: 'child body')
+      child_message.parent = parent_message
+      child_message.save!
+
+      expect(parent_message.subtree.to_a).to include(parent_message, child_message)
+    end
+  end


This specs are to specific. We should send group message, reply to message and check if tree is right. Not modify parents and stuff

Refactored tree structure tests to use the messaging API (send_message, reply_to) instead of low-level parent assignment. Tests now verify root, subtree, and conversation order through actual message replies. (8a656ad)

…el parent assignment Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Initial plan

ea8ae7c

Copilot AI assigned Copilot and LTe Jan 31, 2026

Copilot started work on behalf of LTe January 31, 2026 10:27 View session

Copilot AI and others added 2 commits January 31, 2026 10:36

Add Mongoid support for acts-as-messageable gem

0b83864

Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Fix code review feedback: remove dead code and escape regex

9c12eaa

Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for Mongoid~~ Add Mongoid support Jan 31, 2026

Copilot AI requested a review from LTe January 31, 2026 10:41

Copilot finished work on behalf of LTe January 31, 2026 10:41

Copilot started work on behalf of LTe January 31, 2026 10:52 View session

Copilot AI and others added 4 commits January 31, 2026 10:59

Refactor: Extract shared Core modules and use mongoid-tree gem

f5504ab

Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Update RBIs [dependabot skip]

ef35a76

Update RBIs [dependabot skip]

77fb420

Address code review feedback: optimize subtree query and clean up

cafb459

Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Copilot AI changed the title ~~Add Mongoid support~~ Add Mongoid support with shared Core modules Jan 31, 2026

Copilot finished work on behalf of LTe January 31, 2026 11:01

Copilot started work on behalf of LTe January 31, 2026 11:18 View session

Merge spec helpers into single file with MONGOID_SPECS flag

cb8cb4b

Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Copilot finished work on behalf of LTe January 31, 2026 11:22

LTe requested changes Jan 31, 2026

View reviewed changes

Copilot started work on behalf of LTe January 31, 2026 11:26 View session

Refactor specs to use shared examples for both ActiveRecord and Mongoid

b0f9b39

Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Copilot AI requested a review from LTe January 31, 2026 11:32

Copilot finished work on behalf of LTe January 31, 2026 11:32

Copilot started work on behalf of LTe January 31, 2026 11:32 View session

Copilot finished work on behalf of LTe January 31, 2026 11:34

LTe marked this pull request as ready for review January 31, 2026 20:23

LTe requested changes Jan 31, 2026

View reviewed changes

Copilot started work on behalf of LTe January 31, 2026 20:28 View session

Refactor: Extract shared ClassBehavior, move tree tests to shared exa…

ae040cb

…mples, add Mongoid CI job Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Copilot AI requested a review from LTe January 31, 2026 20:33

Copilot finished work on behalf of LTe January 31, 2026 20:33

LTe requested changes Jan 31, 2026

View reviewed changes

Copilot started work on behalf of LTe January 31, 2026 20:38 View session

Refactor tree structure tests to use messaging API instead of low-lev…

8a656ad

…el parent assignment Co-authored-by: LTe <160962+LTe@users.noreply.github.com>

Copilot AI requested a review from LTe January 31, 2026 20:40

Copilot finished work on behalf of LTe January 31, 2026 20:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Mongoid support with shared Core modules#908

Add Mongoid support with shared Core modules#908
Copilot wants to merge 11 commits intomasterfrom
copilot/add-mongoid-support

Copilot AI commented Jan 31, 2026 •

edited

Loading

Uh oh!

LTe Jan 31, 2026

Uh oh!

LTe Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

LTe Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

LTe Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

LTe Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

LTe Jan 31, 2026

Uh oh!

Copilot AI Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Refactoring Mongoid support to reduce code duplication

Changes Made

Tree Structure Tests (Revised)

Comments on the Issue (you are @copilot in this section)

Uh oh!

LTe Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

LTe Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

LTe Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

LTe Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

LTe Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

LTe Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 31, 2026 •

edited

Loading