Fix #1497 - Delete FTS records before adding new ones for a single track#1506
Open
michaelherger wants to merge 1 commit intopublic/9.1from
Open
Fix #1497 - Delete FTS records before adding new ones for a single track#1506michaelherger wants to merge 1 commit intopublic/9.1from
michaelherger wants to merge 1 commit intopublic/9.1from
Conversation
We can't rely on `INSERT OR REPLACE`, as the `id` column in the full text index isn't unique. Create a `DELETE` request instead. That's not very efficient, but should do the job? Signed-off-by: Michael Herger <[email protected]>
Contributor
|
I'm testing this and have come across another problem: we're only processing the primary_artist from tracks, so additions/deletions of other contributors to the track are not being reflected in fulltext. I'm working on the SQL solution to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't rely on
INSERT OR REPLACE, as theidcolumn in the full text index isn't unique. Create aDELETErequest instead. That's not very efficient, but should do the job?@darrell-k this PR does not include the
workspart yet.