Decode UTF-8 name in html form parameters#1435
Open
shirosaki wants to merge 1 commit intoLMS-Community:public/9.1from
Open
Decode UTF-8 name in html form parameters#1435shirosaki wants to merge 1 commit intoLMS-Community:public/9.1from
shirosaki wants to merge 1 commit intoLMS-Community:public/9.1from
Conversation
A plugin uses non-ascii names in form. It is required to decode as UTF-8.
Member
|
Could you please provide an example use case? I can successfully eg. search for "Šuma Čovjek" already. There are two non-latin characters in there. |
Author
|
@michaelherger The above plugin code expects |
Contributor
|
Maybe I should change the UDN in LMS-Raop? That would be a breaking change meaning that all players would to be re-discovered, but isn't it the more appropriate place to make a change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plugin uses non-ascii names in form.
It is required to decode as UTF-8.