Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optimize cache #295

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Feature/optimize cache #295

merged 7 commits into from
Nov 1, 2023

Conversation

KIwabuchi
Copy link
Member

@KIwabuchi KIwabuchi commented Oct 29, 2023

This PR is for a completely new object cache implementation.

The new cache is:

  • Uses much less memory
  • Significantly faster initialization time, especially on a machine that has many CPU cores
  • More compact and packed internal data structure
  • Yet, achieves the same Metall performance on the dynamic graph construction workload

Simple create and close test results (just creating and closing Metall manager).

  • New ver
    Create 0.0440739s
    Close 0.00165344s

  • Old ver
    Open 0.658001s
    Close 0.116477s

@KIwabuchi KIwabuchi merged commit a2225e5 into develop Nov 1, 2023
4 checks passed
@KIwabuchi KIwabuchi deleted the feature/optimize_cache branch November 1, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant