Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpointing (quasi-Newton solver) #693
Checkpointing (quasi-Newton solver) #693
Changes from 12 commits
7a939b7
181f7f9
0e428f5
354b82b
a14a445
d497955
8b2342c
d4900a9
3579828
d213774
4a9fbf1
0498564
085eb88
b21c3c5
bfe1b40
5bc2af6
a664e35
261ccf9
0506d38
b785475
adf30e6
4e673d5
77c88a2
5631b6c
ea5cafd
28c4567
27d15f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style Guidelines.
There should be spaces before and after each operator, e.g. line 1675, 1655,...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you be more specific about the guideline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean space before and after operator "==".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our CMake build that uses BLT auto formats everything using clang-format (and a configuration file) with a
make style
. Alsomake check
verifies that the code matches the clang-format style configuration, so a PR can't be merged without complying with the style.