Some updates to PDFastSimPAR + using new OpDetBTR #154

calcuttj · 2025-04-07T18:42:24Z

Refer to LArSoft/lardataobj#48 for the changes to OpDetBackTrackerRecord

This includes some simplification in PDFastSimPAR_module.cc + a change to the ScintTimeLAr tool which adds an explicit flag for disabling simulating the fast/slow rise times. This is less error prone/confusing than doing it by context (current implementation).

…odule

FNALbuild · 2025-04-07T18:42:51Z

A new Pull Request was created by @calcuttj (Jake Calcutt) for develop.

It involves the following packages:

larsim

@LArSoft/level-2-managers, @LArSoft/level-1-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

FNALbuild · 2025-04-07T18:42:51Z

The code-checks are being triggered in jenkins.

FNALbuild · 2025-04-07T18:43:04Z

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larsim/MCCheater/PhotonBackTracker.cc \ 
  larsim/PhotonPropagation/PDFastSimPAR_module.cc \ 
  larsim/PhotonPropagation/ScintTimeTools/ScintTimeLAr.cc

Then commit the changes and push them to your PR branch.

FNALbuild · 2025-04-10T15:45:56Z

Pull request #154 was updated. @LArSoft/level-2-managers, @LArSoft/level-1-managers can you please check and sign again.

FNALbuild · 2025-04-10T15:45:56Z

The code-checks are being triggered in jenkins.

FNALbuild · 2025-04-10T15:46:10Z

+code-checks

lgarren · 2025-04-14T15:58:33Z

trigger build with pull requests #154, LArSoft/lardataobj#48

FNALbuild · 2025-04-25T15:45:34Z

-LArSoft tests failed on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/26104&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-04-25T15:45:44Z

-LArSoft tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/26103&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

lgarren · 2025-04-25T17:57:26Z

trigger build with pull requests #154, LArSoft/lardataobj#48

FNALbuild · 2025-04-25T17:57:52Z

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/lardataobj#48

FNALbuild · 2025-04-25T18:11:34Z

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/26110&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-04-25T18:11:36Z

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/26110&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-04-25T18:14:39Z

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/26111&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-04-25T18:14:40Z

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/26111&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

FNALbuild · 2025-04-25T18:35:13Z

-ICARUS tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/11940&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26110&builds=

FNALbuild · 2025-04-25T18:35:14Z

-ICARUS tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/11940&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26110&builds=

FNALbuild · 2025-04-25T18:35:19Z

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/12134&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26110&builds=

FNALbuild · 2025-04-25T18:35:20Z

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/12134&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26110&builds=

FNALbuild · 2025-04-25T18:38:59Z

-SBND tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/16953&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26110&builds=

FNALbuild · 2025-04-25T18:39:00Z

-SBND tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/16953&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26110&builds=

FNALbuild · 2025-04-25T18:42:19Z

-DUNE tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/19375&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26110&builds=

FNALbuild · 2025-04-25T18:42:20Z

-DUNE tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/19375&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/26110&builds=

lgarren · 2025-04-25T21:58:20Z

approve

calcuttj added 8 commits April 4, 2025 16:26

Trying to change a few things in PDFastSimPAR to make it run faster

bf672c6

Some print statements

baae556

Adding discretizing module. Have some output to help diagnose stuff

286db32

Removing Discretize module

8159daa

Adding in explicit check for skipping Fast and Slow rising times

8ee99be

Integrating new version of OpDetBTR into PhotonBackTracker

51b9264

Removing test/dev stuff and simplifying some things in PDFastSimPAR_m…

8ddfe7e

…odule

Removing one more commented line

e16bcb6

FNALbuild added L1-pending code-checks-pending L2-pending signatures-pending tests-pending labels Apr 7, 2025

FNALbuild added code-checks-rejected and removed code-checks-pending labels Apr 7, 2025

Code formatting

3a46885

FNALbuild added code-checks-pending and removed code-checks-rejected labels Apr 10, 2025

FNALbuild added code-checks-approved and removed code-checks-pending labels Apr 10, 2025

knoepfel added this to LArSoft pull requests Apr 14, 2025

knoepfel moved this to Awaiting triage in LArSoft pull requests Apr 14, 2025

knoepfel moved this from Awaiting triage to Approval in progress in LArSoft pull requests Apr 14, 2025

FNALbuild added tests-started and removed tests-pending labels Apr 25, 2025

FNALbuild added tests-pending and removed tests-started labels Apr 25, 2025

FNALbuild added requires-external tests-started and removed tests-pending labels Apr 25, 2025

FNALbuild added L1-approved and removed L1-pending labels Apr 25, 2025

lgarren moved this from Approval in progress to Approved and pending inclusion in release in LArSoft pull requests Apr 25, 2025

lgarren merged commit 0106c64 into LArSoft:develop Apr 29, 2025
1 check passed

github-project-automation bot moved this from Approved and pending inclusion in release to Merged into develop in LArSoft pull requests Apr 29, 2025

lgarren moved this from Merged into develop to Included in release in LArSoft pull requests Apr 29, 2025

Some updates to PDFastSimPAR + using new OpDetBTR #154

Some updates to PDFastSimPAR + using new OpDetBTR #154

Uh oh!

Conversation

calcuttj commented Apr 7, 2025

Uh oh!

FNALbuild commented Apr 7, 2025

Uh oh!

FNALbuild commented Apr 7, 2025

Uh oh!

FNALbuild commented Apr 7, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

FNALbuild commented Apr 10, 2025

Uh oh!

lgarren commented Apr 14, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

lgarren commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

FNALbuild commented Apr 25, 2025

Uh oh!

lgarren commented Apr 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants