Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle J22 logic for detecting if a console is interactive #59

Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat: Handle J22 logic for detecting if a console is interactive #59

merged 2 commits into from
Dec 10, 2024

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Dec 1, 2024

noticed this when looking at #57, needs testing

@zml2008 zml2008 added the enhancement New feature or request label Dec 1, 2024
@zml2008 zml2008 added this to the 1.1.1 milestone Dec 1, 2024
kashike
kashike previously requested changes Dec 2, 2024
View reviewed changes
src/main/java22/net/kyori/ansi/SystemConsole.java Outdated Show resolved Hide resolved
@zml2008 @kashike
remove inaccurate comment
4c71ef6 
Co-authored-by: Riley Park <[email protected]>
@zml2008 zml2008 requested a review from kashike December 7, 2024 20:27
@zml2008 zml2008 self-assigned this Dec 10, 2024
@zml2008 zml2008 added this pull request to the merge queue Dec 10, 2024
Merged via the queue into trunk with commit cdb525c Dec 10, 2024
5 checks passed
@zml2008 zml2008 deleted the feat/j22-terminal-check branch December 10, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashike kashike Awaiting requested review from kashike

Assignees

@zml2008 zml2008

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@zml2008 @kashike