-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds progress and repeat tags #768
base: main/4
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments, but looking good so far!
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/resolver/Formatter.java
Outdated
Show resolved
Hide resolved
text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/resolver/Formatter.java
Outdated
Show resolved
Hide resolved
...message/src/test/java/net/kyori/adventure/text/minimessage/tag/standard/ProgressTagTest.java
Show resolved
Hide resolved
...inimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/StandardTags.java
Show resolved
Hide resolved
TBH: I don't see the usecase for some stuff: Why would you want to provide a static progress? Where would you use a tag from your unit tests? Same stuff with the repeating tag. It could be nice to repeat some stuff but why is there no way for the api to provide a number? Both progress and repeating tags shouldn't be considered as StandardTags. And I disagree with the double supplier. Other tag resolver such as Placeholders or the existing Formatters don't have a Supplier, using Supplier now without a fallback to no supplier is a change in the api. |
The initial idea behind both of these tags was to allow "placeholders" from different places, to be represented in ways not possible simply. You can use a double placeholder provided by some plugin like PAPI or even your own mini message placeholders and convert that into a progress bar without any extra effort. Something like Same with the repeat tag. The repeat tag also makes it easier to edit repeated things. Surely you can write |
No description provided.