Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy button covering content (closes #137) #138

Open
wants to merge 2 commits into
base: main/4
Choose a base branch
from
Open

Conversation

MiniDigger
Copy link
Member

@MiniDigger MiniDigger commented Jul 29, 2023

untested (only in browser)

@MiniDigger MiniDigger linked an issue Jul 29, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jul 29, 2023

Your pull request has been made available for preview at:

https://kyoripowered.github.io/adventure-docs-previews/pull/138/

Last deployed: fea9183. This deployment will expire after 90 days.

@Joo200
Copy link
Contributor

Joo200 commented Jul 29, 2023

that doesn't change anything?
grafik

@Joo200
Copy link
Contributor

Joo200 commented Jul 29, 2023

Changing the text style to margin-right: 2pem instead looks a lot better but I'm not a web dev:
grafik

@MiniDigger
Copy link
Member Author

Changing the text style to margin-right: 2pem instead looks a lot better but I'm not a web dev: grafik

thats how it looks with padding too:
https://i.imgur.com/4Nv1JBf.png
force refresh and make sure the style is actually pulled in, as the first commit was broken

@Joo200
Copy link
Contributor

Joo200 commented Jul 29, 2023

force refresh and make sure the style is actually pulled in, as the first commit was broken

Yes, I made sure and validated the correct style in the developer tools from Firefox. With Chromium the result looks correct and like your example, but Firefox has still an overlapped copy button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copy to clipboard covering text
2 participants