fix: test flakes #1742
Draft
fix: test flakes #1742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/extension/oop_test.go
Outdated
| //} | ||
|
|
||
| // TODO: Revisit but commented out due to it's flaky | ||
| //func TestOOPExtensionForwardsLog(t *testing.T) { |
Member
There was a problem hiding this comment.
I'd actually looked into this one and I've maybe got a potential fix; just a bit harder to reproduce
Member
There was a problem hiding this comment.
I was thinking this might help #1744
I thought it might be the 50ms wait is inconsistent in the test runners so instead of waiting a fixed time I've exposed the wait itself just for the test.. if it doesn't fix things though happy to potentially disable this test
Signed-off-by: KevFan <kevin_fan@hotmail.co.uk>
…lake Signed-off-by: KevFan <kevin_fan@hotmail.co.uk>
Signed-off-by: KevFan <kevin_fan@hotmail.co.uk>
Signed-off-by: KevFan <kevin_fan@hotmail.co.uk>
Signed-off-by: KevFan <kevin_fan@hotmail.co.uk>
Signed-off-by: KevFan <kevin_fan@hotmail.co.uk>
Signed-off-by: KevFan <kevin_fan@hotmail.co.uk>
Signed-off-by: KevFan <kevin_fan@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desription
Fix/comment out test flakes to hopefully make test pipeline more stable