Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(ToggleComposites): Fix server delete composite handling #1536

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

Kruptein
Copy link
Owner

When moving shapes to a different location, the client sends which shapes to move and the server will move them and inform any client still on the old location which shapes to remove.

The server will check for each shape whether it's part of a toggle composite and move all variants along as well. It will also the variants to the list of shapes it sends to clients on the old location to remove.

The client however can sometimes also include the list of variants already in its original move request and the server was not handling this correctly, resulting in multiple requests to remove the same variants to be sent to some clients which would throw an error when they have to remove something a second time when it's already removed.

TL;DR The server now takes into account shapes already handled when moving them

@Kruptein Kruptein merged commit 2b45459 into dev Jan 19, 2025
6 checks passed
@Kruptein Kruptein deleted the bugfix/server-composite-delete branch January 19, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant