bug(ToggleComposites): Fix server delete composite handling #1536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving shapes to a different location, the client sends which shapes to move and the server will move them and inform any client still on the old location which shapes to remove.
The server will check for each shape whether it's part of a toggle composite and move all variants along as well. It will also the variants to the list of shapes it sends to clients on the old location to remove.
The client however can sometimes also include the list of variants already in its original move request and the server was not handling this correctly, resulting in multiple requests to remove the same variants to be sent to some clients which would throw an error when they have to remove something a second time when it's already removed.
TL;DR The server now takes into account shapes already handled when moving them