fix(pluginform): remove reset type of cancel button #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiarrowood
deleted the
fix/KM-882-duplicate-call-of-handle-click-cancel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KM-882
EntityBaseFormhas a built-in method for reset events(https://github.com/Kong/public-ui-components/blob/fix/KM-882-duplicate-call-of-handle-click-cancel/packages/entities/entities-shared/src/components/entity-base-form/EntityBaseForm.vue#L30), so thehandleClickCancelis triggered twice when cancel button is clicked(once by click event of button, once by cancel event triggered by form reset event).Normally this not a problem because when
handleClickCancelexecutes for the first time,router.push(props.config.cancelRoute)goes to another page so that the current component no longer exists and the second execution ofhandleClickCancelwon't happen. However, if noprops.config.cancelRouteis passed, then duplicate calls ofhandleClickCancelsurface.So i removed
type="reset"for cancel button sincehandleClickCancelalready handles click event of cancel button.