Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expressions): expose editor #1876

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(expressions): expose editor #1876

merged 1 commit into from
Jan 9, 2025

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Jan 2, 2025 •
edited
Loading

Summary

Expose the editor instance for the consuming app.

@Leopoldthecoder Leopoldthecoder force-pushed the feat/expose-editor branch 3 times, most recently from c64a955 to c3df6b9 Compare January 7, 2025 03:21
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review January 9, 2025 03:50
@Leopoldthecoder Leopoldthecoder requested a review from a team as a code owner January 9, 2025 03:50
sumimakito
sumimakito approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 6eabc32 into main Jan 9, 2025
10 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/expose-editor branch January 9, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito sumimakito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @sumimakito