Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics-chart): render timeseries charts with a single point [MA-2682] #1872

Closed
wants to merge 1 commit into from

Conversation

ryanmoore
Copy link

Summary

When a line chart is asked to display a single data point, display that datapoint with a radius smaller than the hover radius instead of displaying a deceptive "No data" error.

Test dataset:

{
  "data": [
    {
      "event": {
        "request_count": 100000
      },
      "timestamp": "2024-12-23T07:00:00.000Z"
    }
  ],
  "meta": {
    "start_ms": 1734937200000,
    "end_ms": 1735023600000,
    "limit": 50,
    "granularity_ms": 86400000,
    "metric_names": [
      "request_count"
    ],
    "truncated": false,
    "display": {},
    "metric_units": {
      "request_count": "count"
    }
  }
}

Before:
image

After:

image

@ryanmoore ryanmoore requested a review from a team as a code owner December 24, 2024 16:24
@CLAassistant
Copy link

CLAassistant commented Dec 24, 2024

CLA assistant check
All committers have signed the CLA.

@ryanmoore
Copy link
Author

reworking based on feedback from @filipgutica

@ryanmoore ryanmoore closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants