-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resource): add resource limits cases #187
base: main
Are you sure you want to change the base?
Conversation
6b159a8
to
ab5c2c0
Compare
Signed-off-by: Jay Chen <[email protected]>
ab5c2c0
to
c753c4a
Compare
Almost LGTM |
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
test/k8s/res_limits_test.go
Outdated
_, _ = fmt.Fprintf(GinkgoWriter, "Pod %s: %s\n", pod.Name, pod.Status.Phase) | ||
for _, cts := range pod.Status.ContainerStatuses { | ||
_, _ = fmt.Fprintf(GinkgoWriter, "Pod %s - %s: %s\n", pod.Name, cts.Name, cts.State.String()) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we printing this? Should this be assertion or what's the reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to print dp statuses to help diagnose issues. For the case when "control plane should not crash", the DPs are also expected to be healthy. So if there is any DP unready, it should be not related to the CP.
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
Signed-off-by: Jay Chen <[email protected]>
4ffd49a
to
c0757e9
Compare
GOMEMLIMIT
.Cases included:
GOMEMLIMIT
set when all services and instances with half CP resourceA lot of metrics are periodically fetched and printed to output, so I'm trying to save it to a file, otherwise it'll be troublesome to open the view for the GHA runs.
fixes #235