-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps) bump luasocket from 3.0-rc1 to 3.0.0 #8590
Conversation
67ea5a6
to
6493d46
Compare
6493d46
to
87b44e9
Compare
Two questions:
|
@alerque, Thanks for getting back. I think we use We do have some M1 patches, but I am not aware that we patch LuaSocket in any way. I need to recheck that though, or is there any monkey patching going on anywhere or within our test suite. |
It's possible I was reading the output wrong, I don't know what I'm looking at here. I just saw something about patching sockets and a If there is anything you need from the LuaSocket side to get this working feel free to raise an issue. And of course if it turns out there is some monkey patching going on we'd be happy to look at upstreaming proper fixes so that everybody benefits. |
87b44e9
to
cd36344
Compare
### Summary The last time LuaSocket had a stable release tag was 14 years ago when 2.0.2 was tagged. A v3 release candidate was tagged 9 years ago. Since then it has been downloaded over 3 million times. Additionally the Git repository regularly gets several hundred clones a day. But 9 years is a long time and even the release candidate has grown a bit long in the tooth. Many Linux distros have packaged the current Git HEAD or some specific tested point as dated or otherwise labeled releases. 256 commits later and having been migrated to the @lunarmodules org namespace on GitHub, please welcome v3. This release is a "safe-harbor" tag that represents a minimal amount of changes to get a release tagged. Beyond some CI tooling, very little code has changed since migration to @lunarmodules ([5b18e47..e47d98f](https://github.com/lunarmodules/luasocket/compare/5b18e47..e47d98f?w=1)): * Lua 5.4.3+ support – @pkulchenko, @Zash * Cleanup minor issues to get a code linter to pass – @Tieske, @jyoui, @alerque * Update Visual Studio build rules for Lua 5.1 – @ewestbrook * Set http transfer-encoding even without content-length – @tokenrove Prior to migration to @lunarmodules ([v3.0-rc1..5b18e47](https://github.com/lunarmodules/luasocket/compare/v3.0-rc1..5b18e47?w=1)) many things happened of which the author of this changelog is not fully apprised. Your best bet if it affects your project somehow is to read the commit log & diffs yourself.
cd36344
to
913acd6
Compare
@alerque, Seems like @Tieske opened an issue related to this on LuaSocket: I am changing this to do not merge until we get resolution from upstream. |
I will close this for now. Let's see if upstream resolves this at some point. |
Summary
The last time LuaSocket had a stable release tag was 14 years ago when 2.0.2 was tagged.
A v3 release candidate was tagged 9 years ago.
Since then it has been downloaded over 3 million times.
Additionally the Git repository regularly gets several hundred clones a day.
But 9 years is a long time and even the release candidate has grown a bit long in the tooth.
Many Linux distros have packaged the current Git HEAD or some specific tested point as dated or otherwise labeled releases.
256 commits later and having been migrated to the @lunarmodules org namespace on GitHub, please welcome v3.
This release is a "safe-harbor" tag that represents a minimal amount of changes to get a release tagged.
Beyond some CI tooling, very little code has changed since migration to @lunarmodules (5b18e47..e47d98f):
Prior to migration to @lunarmodules (v3.0-rc1..5b18e47) many things happened of which the author of this changelog is not fully apprised.
Your best bet if it affects your project somehow is to read the commit log & diffs yourself.