Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapcraft update [INS-3645] #8015

Closed
wants to merge 7 commits into from
Closed

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Sep 26, 2024

WIP,

Closes INS-3645

Trying to close #7106, #7138

Related PR electron-userland/electron-builder#8549

Experiments

test1:

  • Ubuntu 16, core22 snap baked on 22.04 🔴 - FAIL: sending requests doesn't work
  • Ubuntu 18, core22 snap baked on 22.04 ✅
  • Ubuntu 20, core22 snap baked on 22.04 ✅
  • Ubuntu 22, core22 snap baked on 22.04 ✅
  • Ubuntu 24, core22 snap baked on 22.04 ✅

test2:

  • Ubuntu 22, core22 snap baked on 24.04 ✅
  • Ubuntu 24, core22 snap baked on 24.04 ✅

test3:

  • Ubuntu 16, core22 with gnome-42-2204 plug baked on 24.04 🔴 - FAIL - segmentation fault
  • Ubuntu 18, core22 with gnome-42-2204 plug baked on 24.04 🔴 - FAIL - segmentation fault

test4:

current blocker

using core24 we get:

error while loading shared libraries: libX11.so.6: cannot open shared object file: No such file or directory

Notes

  • Might need further changes on electron-builder side first. Initial attempt made is just trying to use only changes on the config on our side.

  • Not looked at yet - when running electron-builder to produce the linux-unpacked bits that go into different packaged versions of Insomnia (.deb, .snap, ...) on ubuntu-latest or on ubuntu-22.04 or ubuntu-20.04 - that could cause different issues with different versions - we need to figure out which one causes lowest amount of trouble. Example - pin ubuntu version #7868

  • Downgrading is a trap Fix #5531 bump snapcraft base to core22 #5555

@filfreire filfreire requested a review from a team September 26, 2024 15:41
@filfreire filfreire marked this pull request as draft September 26, 2024 15:43
@filfreire filfreire self-assigned this Sep 26, 2024
@filfreire filfreire closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snap package fails due to missing dependency
1 participant