Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP,
Closes INS-3645
Trying to close #7106, #7138
Related PR electron-userland/electron-builder#8549
Experiments
test1:
test2:
test3:
test4:
current blocker
using
core24
we get:Notes
Might need further changes on electron-builder side first. Initial attempt made is just trying to use only changes on the config on our side.
Not looked at yet - when running electron-builder to produce the linux-unpacked bits that go into different packaged versions of Insomnia (.deb, .snap, ...) on
ubuntu-latest
or onubuntu-22.04
orubuntu-20.04
- that could cause different issues with different versions - we need to figure out which one causes lowest amount of trouble. Example - pin ubuntu version #7868Downgrading is a trap Fix #5531 bump snapcraft base to core22 #5555