Adds paths information in 3.4.x compatibility warn #144
Conversation
|
|
khaikong
force-pushed
the
diff-debugging
branch
from
1007aa9 to
541e982
Compare
|
@khaikong Could you rebase the branch with main and rectify the lint errors that CI is throwing? |
khaikong
force-pushed
the
diff-debugging
branch
from
81a4046 to
fa3b03b
Compare
khaikong
force-pushed
the
diff-debugging
branch
from
fa3b03b to
0600c8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 28.72% 28.72%
=======================================
Files 106 106
Lines 15814 15814
=======================================
Hits 4542 4542
Misses 10793 10793
Partials 479 479 ☔ View full report in Codecov by Sentry. |
|
@Prashansa-K Done! Could you please check |
|
@khaikong Could you please check the pending item? |
|
@khaikong I am planning a deck release for tomorrow. Do you think this can be wrapped up by then so that it can be part of next release? |
pkg/file/builder.go
Outdated
| @@ -982,7 +982,7 @@ func (b *stateBuilder) routes() { | |||
| } | |||
| for _, r := range allRoutes { | |||
| if utils.HasPathsWithRegex300AndAbove(r.Route) { | |||
| unsupportedRoutes = append(unsupportedRoutes, *r.Route.ID) | |||
| unsupportedRoutes = append(unsupportedRoutes, *r.Route.ID + " paths:" + *r.Route.Paths[0]) | |||
There was a problem hiding this comment.
What if there are >1 paths?
Can we account for the same and then list the paths?
There was a problem hiding this comment.
@khaikong This is still pending.
|
@Prashansa-K could you wait till next week. Will try to finish this next week. |
Summary
When running
deck diffon Kong 3.4.x we can see below error:As there are hundred of regex route and the error causing the pipeline to stop. There are no way currently to determine the problematic route.
There is a workaround for this issue by running
deck convertbut I would like to see the affected route first before running the command.Full changelog
Testing