Skip to content

[Nextor 3] Fix key scanning for disk change on floppy emulation mode#188

Merged
Konamiman merged 1 commit intov3.0from
nextor3/fix-disk-emulation-mode-disk-change-keys
Jan 29, 2026
Merged

[Nextor 3] Fix key scanning for disk change on floppy emulation mode#188
Konamiman merged 1 commit intov3.0from
nextor3/fix-disk-emulation-mode-disk-change-keys

Conversation

@Konamiman
Copy link
Owner

@Konamiman Konamiman commented Jan 29, 2026

"Backport" of #161

Part of #164

@Konamiman Konamiman added this to the v3.0.0 alpha 1 milestone Jan 29, 2026
@github-project-automation github-project-automation bot moved this to Backlog in Nextor 3 Jan 29, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

The CHGLOOP rotation and shift sequence in source/kernel/drv.mac was reordered, changing from sra c; rr e; rr d; ...; rr h to srl h; rr l; rr d; rr e; rr c. This alters the sequence and timing of register operations within the loop iteration while maintaining the subsequent bit test logic.

Changes

Cohort / File(s) Summary
Register Rotation Sequence
source/kernel/drv.mac
Reordered the rotation/shift instructions in CHGLOOP from sra c; rr e; rr d; ...; rr h to srl h; rr l; rr d; rr e; rr c, changing the progression of register updates and key index advancement per loop iteration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 With whiskers twitching, I rearrange,
The register dance in loops most strange,
From C to E, now H leads the way,
Each rotation spins a different day! 🔄

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: a fix to key scanning for disk change in floppy emulation mode, directly matching the file modification in CHGLOOP.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Konamiman Konamiman marked this pull request as ready for review January 29, 2026 14:58
@Konamiman Konamiman merged commit e3addf4 into v3.0 Jan 29, 2026
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Nextor 3 Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant