Skip to content

[Nextor 3] Fix "map to device sector 0" option in CALL MAPDRV#181

Merged
Konamiman merged 1 commit intov3.0from
nextor3/fix/call-mapdrv-to-sector-0
Jan 28, 2026
Merged

[Nextor 3] Fix "map to device sector 0" option in CALL MAPDRV#181
Konamiman merged 1 commit intov3.0from
nextor3/fix/call-mapdrv-to-sector-0

Conversation

@Konamiman
Copy link
Owner

@Konamiman Konamiman commented Jan 28, 2026

"Backport" of #151

Part of #164

@Konamiman Konamiman added this to the v3.0.0 alpha 1 milestone Jan 28, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

A control flow modification in the partition mapping driver adjusts the jump target for primary partition handling in MAPDRV_GETCUR, inserting an intermediate label MAPDRV_GOT_PAR_SEC to route execution through a new two-step path before the mapping logic executes.

Changes

Cohort / File(s) Summary
Partition mapping control flow
source/kernel/bank4/partit.mac
Modified MAPDRV_GETCUR jump target from MAPDRV_GOTPAR to MAPDRV_GOT_PAR_SEC; added new intermediate label prior to mapping section for partition sector handling

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • #175 — Modifies BC save/restore behavior around MAPDRV/UNMAPALL calls in the same file
  • #174 — Adjusts MAPDRV mapping paths and control flow in partit.mac, affecting the same code sections

Poem

🐰 A hop through the partition's maze,
With new labels lighting the way,
Two steps instead of one direct blaze,
The mapping driver saves the day!
Control flow clean, the sectors align,
This tiny tweak makes it just fine! 🎯


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-project-automation github-project-automation bot moved this to Backlog in Nextor 3 Jan 28, 2026
@Konamiman Konamiman moved this from Backlog to In review in Nextor 3 Jan 28, 2026
@Konamiman Konamiman marked this pull request as ready for review January 28, 2026 12:39
@Konamiman Konamiman merged commit 8b69576 into v3.0 Jan 28, 2026
0 of 2 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Nextor 3 Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant