Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataArray): warn on default data type #3183

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix(DataArray): warn on default data type #3183

merged 1 commit into from
Dec 5, 2024

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Dec 3, 2024 •
edited
Loading

Context

Addresses #3172. Notify users that data arrays are becoming Float32Arrays when given a plain JS array with no explicit data type.

@sedghi

Results

  • Code that use data arrays with plain JS arrays and no explicit data type will now log a warning.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@floryst floryst requested a review from jourdain December 3, 2024 15:46
@sedghi
Copy link
Contributor

sedghi commented Dec 3, 2024

Oh this was on my todo list to do, thanks Forrest

@floryst floryst added this pull request to the merge queue Dec 5, 2024
Merged via the queue into master with commit ba39aae Dec 5, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

🎉 This PR is included in version 32.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jourdain jourdain jourdain approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floryst @sedghi @jourdain