More conventional syntax of -I command line argument in tool cpp_to_pybind
#351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed syntax of command line argument -I Until now to add multiple paths, you had to put them into one long quotation-mark-separated string, individual paths separated by spaces. This is not viable for paths including space characters and is also rather unconventional. Instead you can now add the "-I" argument multiple times. This is the approach used by e.g. compilers like clang or gcc
cafhach
changed the title
cpp_to_pybindcpp_to_pybind
cafhach
changed the title
cpp_to_pybind-I command line argument in tool cpp_to_pybind
This case didn't work in the trunk version either. I assumed what was meant there and implemented it using `os.path.dirname`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed syntax of command line argument
-IUntil now to add multiple paths, you had to put them into one long quotation-mark-separated string, individual paths separated by spaces. This is not viable for paths including space characters and is also rather unconventional. Instead you can now add the
-Iargument multiple times. This is the approach used by e.g. compilers like clang or gcc