Skip to content

Commit

Permalink
Use storage_path on ctest submit for validation
Browse files Browse the repository at this point in the history
When attempting to validate an HTTP submission use the `storage_path` helper
to turn the filename which starts at the inproess folder, `inprocess/<>.xml`,
to a full path.  This should not affect the path given directly to the
submission:validate artisan command.
  • Loading branch information
josephsnyder committed Sep 25, 2024
1 parent 304ac32 commit d94a42b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/cdash/include/ctestparser.php
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ function ctest_parse($filehandle, string $filename, $projectid, $expected_md5 =
// If validation is enabled and if this file has a corresponding schema, validate it
if (((bool) config('cdash.validate_xml_submissions')) === true && isset($schema_file)) {
try {
SubmissionUtils::validate_xml($filename, $schema_file);
SubmissionUtils::validate_xml(storage_path("app/".$filename), $schema_file);
} catch (CDashXMLValidationException $e) {
foreach ($e->getDecodedMessage() as $error) {
Log::error("Validating $filename: ".$error);
Expand Down

0 comments on commit d94a42b

Please sign in to comment.