Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting reapply_cors logic to return the first match #3471

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adjusting reapply_cors logic to return the first match #3471

wants to merge 2 commits into from

Conversation

alexcottner
Copy link
Contributor

@alexcottner alexcottner commented Nov 21, 2024 •
edited
Loading

Adjusting reapply_cors logic to return the first match instead of the domain provided. This fixes an issue where we want to always return *.

  • Add tests.

@alexcottner alexcottner marked this pull request as ready for review January 13, 2025 20:00
@alexcottner alexcottner changed the title WIP - Adjusting reapply_cors logic to return the first match Adjusting reapply_cors logic to return the first match Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoneiser ahoneiser ahoneiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcottner @ahoneiser