Skip to content

Commit

Permalink
Fix SQLAlchemy integration (#3136)
Browse files Browse the repository at this point in the history
* Use documented way to enable SQLAlchemy integration

* Reinstall project when `setup.cfg` changes

* Update changelog
  • Loading branch information
grahamalama authored Feb 8, 2023
1 parent c3d1bfa commit 68376a6
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ This document describes changes between each past release.
15.1.1 (unreleased)
-------------------

- Nothing changed yet.
**Bug Fixes**

- Use correct import path for SQLAlchemy Sentry integration


15.1.0 (2023-02-08)
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ help:

all: install
install: $(INSTALL_STAMP)
$(INSTALL_STAMP): $(PYTHON) setup.py requirements.txt
$(INSTALL_STAMP): $(PYTHON) setup.py requirements.txt setup.cfg
$(VENV)/bin/pip install -U pip
$(VENV)/bin/pip install -Ue . -c requirements.txt
touch $(INSTALL_STAMP)
Expand Down
3 changes: 2 additions & 1 deletion kinto/core/initialization.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
ProfilerMiddleware = False
try:
import sentry_sdk
from sentry_sdk.integrations.pyramid import PyramidIntegration, SqlalchemyIntegration
from sentry_sdk.integrations.pyramid import PyramidIntegration
from sentry_sdk.integrations.sqlalchemy import SqlalchemyIntegration
except ImportError: # pragma: no cover
sentry_sdk = None

Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ postgresql =
zope.sqlalchemy
monitoring =
newrelic
sentry-sdk
sentry-sdk[sqlalchemy]
statsd
werkzeug

Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ deps =
-r{toxinidir}/dev-requirements.txt
psycopg2
newrelic
sentry-sdk
sentry-sdk[sqlalchemy]
statsd
install_command = pip install {opts} {packages} -c{toxinidir}/requirements.txt

Expand Down

0 comments on commit 68376a6

Please sign in to comment.