- make it like a uuid

KinNeko-De · Feb 11, 2024 · 793a8a1 · 793a8a1
1 parent 00706c0
commit 793a8a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/Sample.HumanFriendlyId.UnitTest/HumanFriendlyIdTests.cs b/Sample.HumanFriendlyId.UnitTest/HumanFriendlyIdTests.cs
@@ -13,7 +13,7 @@ public void Id_IsGenerated()
         var sut = new HumanFriendlyId(length);
         var actualId = sut.Id;
 
-        Assert.That(actualId.Length, Is.EqualTo(16));
+        Assert.That(actualId, Has.Length.EqualTo(length));
         Assert.That(actualId, Does.Match($"^[{allowedChars}]+$"));
     }
 
@@ -31,7 +31,7 @@ public void DisplayId_IsGroupedBySpaces(int length, int expectedLength)
 
         string regex = CreateRegex(length);
 
-        Assert.That(actualDisplayId.Length, Is.EqualTo(expectedLength));
+        Assert.That(actualDisplayId, Has.Length.EqualTo(expectedLength));
         Assert.That(actualDisplayId, Does.Match(regex));
     }
 

diff --git a/Sample.HumanFriendlyId/HumanFriendlyId.cs b/Sample.HumanFriendlyId/HumanFriendlyId.cs
@@ -2,23 +2,23 @@
 
 namespace Sample.HumanFriendlyId;
 
-public class HumanFriendlyId
+public readonly struct HumanFriendlyId
 {
     const string chars = "ABCDEFGHJKLMNPQRSTUVWXYZ123456789";
 
     public HumanFriendlyId(int length) : this(RandomNumberGenerator.GetItems<char>(chars, length))
     {
     }
 
-    protected HumanFriendlyId(char[] humanFriendlyId)
+    private HumanFriendlyId(char[] humanFriendlyId)
     {
         Id = new string(humanFriendlyId);
         DisplayId = new string(GroupBySpaces(humanFriendlyId).ToArray());
     }
 
-    public string Id { get; private set; }
+    public readonly string Id { get; private init; }
 
-    public string DisplayId { get; private set; }
+    public readonly string DisplayId { get; private init; }
 
     public static HumanFriendlyId Parse(string userInput)
     {