Adding Test Coverage to Cover the fields.py file for LayerField and LayerFieldsContainer Classes #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipscoderepo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #701 Tested on Windows 11, Python 3.12.0
This pull request addresses a lack of test coverage for the LayerField and LayerFieldsContainer classes in the source file src/pyshark/packet/fields.py. These tests ensure that functions performing value conversions and string formatting produce the expected results when provided certain values, as well as some functional testing for functions used to modify values within the class.
A new test source file will be added to the tests folder under a new packet directory, which, can also contain tests for the other files under the src/pyshark/packet directory. These tests use the standards pytest library, and follow the same testing conventions as existing tests in the repository.