Add fifo option to FileCapture #621
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XChikuX
suggested changes
Jan 31, 2023
| @@ -120,7 +120,7 @@ def __getattr__(self, item): | |||
| Allows layers to be retrieved via get attr. For instance: pkt.ip | |||
| """ | |||
| for layer in self.layers: | |||
| if layer.layer_name == item: | |||
| if layer.layer_name.lower() == item: | |||
There was a problem hiding this comment.
Change to:
if layer.layer_name.lower() == item.lower():
|
There appear to be a bunch of unrelated things in this PR, please only contain the feature in the PR title. |
KimiNewt
reviewed
Apr 26, 2023
| params = super(LiveCapture, self).get_parameters( | ||
| packet_count=packet_count) | ||
| # Read directly from interfaces | ||
| for interface in self.interfaces: |
There was a problem hiding this comment.
This isn't related to this PR, and there's a reason we use dumpcap and don't read directly from the interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows FileCapture to read from a FIFO, which can be useful for parsing the kismet pcapng stream.