Skip to content

Fix MCP server recursive behavior patterns #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MCP server recursive behavior patterns #1988

wants to merge 1 commit into from

Conversation

OleksandrKucherenko
Copy link

Summary

This PR resolves critical recursive behavior issues in the MCP server management system identified in issue #1986.

Changes Made

  • McpHub.ts: Added debouncing with exponential backoff (500ms-8s), connection state locking, and process termination verification
  • McpServerManager.ts: Enhanced singleton pattern thread safety and reference counting integration
  • Task.ts: Implemented sequential initialization coordination with timeout management

Fixes Applied

  1. ✅ File watcher infinite restart loops with debouncing mechanism
  2. ✅ Singleton race condition prevention with atomic operations
  3. ✅ Configuration cascade restart avalanches with state locking
  4. ✅ Cleanup race conditions with proper process termination
  5. ✅ Concurrent initialization chaos with sequential coordination
  6. ✅ Task-level MCP access storms with timeout management
  7. ✅ Error-driven restart feedback loops with comprehensive error handling

Testing

  • ✅ All 42 MCP Hub tests passing
  • ✅ 32 Task module tests passing (4 skipped)
  • ✅ Type checking clean across all packages
  • ✅ Linting passed with no warnings or errors

Technical Impact

  • Eliminates recursive restart loops that could hang the MCP system
  • Prevents race conditions in server initialization and cleanup
  • Enhances system stability with proper error handling and timeouts
  • Maintains backward compatibility with existing MCP functionality

Resolves #1986

@alexkucherenko
fix: resolve MCP server recursive behavior patterns
3592aa1 
- Fix file watcher infinite restart loops with debouncing (500ms-8s exponential backoff)
- Implement connection state locking mechanism to prevent race conditions
- Add process termination verification to avoid zombie processes
- Enhance singleton pattern thread safety in McpServerManager
- Add sequential initialization coordination in Task module
- Improve error handling and cleanup throughout MCP system

Resolves GitHub issue Kilo-Org#1986

Changes:
- McpHub.ts: debouncing, locking, process cleanup
- McpServerManager.ts: thread-safe singleton, reference counting
- Task.ts: sequential initialization with timeout management

Tests: All 42 MCP tests passing, type checking and linting clean
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2025

⚠️ No Changeset found

Latest commit: 3592aa1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] MCP Server Recursive Startup and Resource Leaks
2 participants
@OleksandrKucherenko @alexkucherenko