Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin for shift without joining it #580

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

KiOui
Copy link
Owner

@KiOui KiOui commented Nov 15, 2024

Closes #533

This PR alters the JoinShiftView to allow a user to go to the admin page without being in the assignees. The user will get redirected to the JoinShiftView once every 10 minutes if accessing the shift admin view without being in the assignees.

@KiOui KiOui added the feature New or improved functionality. label Nov 15, 2024
@KiOui KiOui self-assigned this Nov 15, 2024
Copy link
Collaborator

@vincevd1 vincevd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I do think it might be a good idea to update the templates a little bit to make clear it is also possible to only manage. Right now just pressing no when wanting to join might be a little bit unclear.

@KiOui
Copy link
Owner Author

KiOui commented Nov 18, 2024

LGTM, however I do think it might be a good idea to update the templates a little bit to make clear it is also possible to only manage. Right now just pressing no when wanting to join might be a little bit unclear.

Thanks for the adjustments, good idea! I'll merge now 😄

@KiOui KiOui merged commit 4399ec6 into master Nov 18, 2024
3 checks passed
@KiOui KiOui deleted the feature/allow-shift-page-without-joining branch November 18, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New or improved functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Een shift kunnen joinen zonder dat je hebt gebakken om orders af te kunnen ronden en de shift te finalizen
2 participants