Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status screens for order venues status screens #578

Merged
merged 13 commits into from
Oct 28, 2024

Conversation

vincevd1
Copy link
Collaborator

This adds a status screen that automatically switches between the original status screen for shifts and a music screen to see what is currently playing.

From what I have seen you do not get logged out of the current session as long as the browser stays open which is the case with thaliedje. So we can just log in with an account with no privileges and put this link on.

I hooked up a monitor in noord to show this screen.

Copy link
Collaborator

@JobDoesburg JobDoesburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, will have to see it live to say something about the styling

@vincevd1
Copy link
Collaborator Author

vincevd1 commented Oct 25, 2024

Styling of the music screen looks like the following:

image

Large text because it has to be able to be seen on the monitor from far away. I could include the next song from the queue as well if needed

@KiOui
Copy link
Owner

KiOui commented Oct 26, 2024

Hey Vince! Thanks for the MR. I have two suggestions:

  • I've created OAuth2 support for one of the status screens, you can find the PR here.
  • I think it would be better if we would put this all into one screen without the need for refreshing. I would do it the following way:
  1. Check if a music player exists, if it does, tell the template to also render a music player.
  2. In the template, check if an active shift exists, if it does, display and refresh that.
  3. If no shift is active, switch over to displaying the music player. If no music player exists, display a message saying that there is no active shift).

I think this is cleaner than refreshing the page (I also got into an infinite refresh loop when testing).

@KiOui KiOui force-pushed the venue-status-screens branch from 6e503ff to 964b301 Compare October 26, 2024 14:49
@KiOui
Copy link
Owner

KiOui commented Oct 26, 2024

@vincevd1 I made some small changes again. I removed the dedicated active shift endpoint in favor of using the list shift endpoint with query parameters

Copy link
Owner

@KiOui KiOui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @vincevd1! Just one small thing and we can merge this 😄 You may also overwrite the old status screen if you want to.

@KiOui KiOui self-requested a review October 27, 2024 10:18
@KiOui KiOui force-pushed the venue-status-screens branch from 22cd211 to b57f5a7 Compare October 27, 2024 10:19
@vincevd1 vincevd1 merged commit 87ccf59 into master Oct 28, 2024
3 checks passed
@vincevd1 vincevd1 deleted the venue-status-screens branch October 28, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants